Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MI-59 exclude all studies #197

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

JanionNevill
Copy link
Collaborator

All studies can now be excluded without crashing the app

@tommorris168
Copy link
Contributor

You could have kept the first PR, because the branch to be merged into can be changed after creation. (In fact, for a while I didn't realise there was any other way of doing it!)

Copy link
Contributor

@tommorris168 tommorris168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is fine, but there is a problem which I assume is from MI-28. If you check the boxes too quickly you go into an infinite loop, where they keep checking and unchecking.

@JanionNevill
Copy link
Collaborator Author

If you check the boxes too quickly you go into an infinite loop, where they keep checking and unchecking.

Nooooo! I thought I'd fixed that!

Can you give me a set of precise reproducible instructions please?

@tommorris168
Copy link
Contributor

I don't think I can. I can reliably reproduce it using the default continuous dataset, but not always at the same point. Sometimes it starts immediately and sometimes not. The only thing I can say with certainty is that if you click them one at a time and watch the table on tab 1a, if you wait for the table to update before the next click then the problem doesn't occur. Good luck!

@JanionNevill
Copy link
Collaborator Author

JanionNevill commented Aug 27, 2024

@tommorris168 I've reverted the disconnected network issue on another branch. Are you happy for this to be merged now?

@tommorris168
Copy link
Contributor

It's crashing when I remove all the studies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants