Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the name of "vsm" to "vsm.py" to make it easier to import the… #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dmiespdx
Copy link

… module.

Added code to allow incoming messages to be dictionaries or simple key/value
pairs.

… module.

Added code to allow incoming messages to be dictionaries or simple key/value
pairs.
@gctucker
Copy link
Collaborator

See also #48 which is about making this a proper Python package with vsm a module inside it to be imported in a standard way.

One issue I hit with #48 was that the commands interpreted from the rules definitions relied on some relative paths to the current directory, making it hard to have this package installed in the standard path.

@dmiespdx
Copy link
Author

I understand that if we install the "vsm.py" module into the Python library directories (/usr/local/lib/python3.6...) and then use "import vsm" in our code to load that module, we might have a problem with relative path names in the rules files. However, I looked at all of the sample rules files and did not find anything that looked like a pathname and I can't think of a case in which a rule would specify a pathname.

Do you have an example of a rule that would cause a problem?

If it's just a theoretical problem, I don't have a problem specifying that any rules that have pathnames in them need to use absolute pathnames.

@dmiespdx dmiespdx changed the title Changed the name of "vsm" to "vsm.py" go make it easier to import the… Changed the name of "vsm" to "vsm.py" to make it easier to import the… Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants