Completed All Tasks #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| class RatingOfBook(models.Model): | ||
| book = models.ForeignKey(Book, on_delete=models.CASCADE) | ||
| ratingValue = models.PositiveIntegerField(null=True, blank=True) |
There was a problem hiding this comment.
You can also use MinValueValidator and MaxValueValidators here to have database level constraints set on this field.
| response_data['message'] = "success" | ||
| bookId = request.POST.get('bookid') | ||
| rating = request.POST.get('ratingOfTheBook') | ||
| BookWhichIsRated = Book.objects.get(id = bookId) |
There was a problem hiding this comment.
PascalCase have different conventions and meanings in Django and in general in python. These are use mostly in class based names or for literal names. snake_case is generally used for naming variables in python.
Comment on lines
+209
to
+218
| Ratings = [x for x in RatingOfBook.objects.filter(book = BookWhichIsRated)] | ||
| l = len(Ratings) | ||
| sum = 0 | ||
| for r in Ratings: | ||
| sum = sum + r.ratingValue | ||
|
|
||
| average_rating = sum/l | ||
| BookWhichIsRated.rating = average_rating | ||
| BookWhichIsRated.save() | ||
|
|
There was a problem hiding this comment.
While this is correct , a more clean and Django-ish way for doing this could be:
It uses aggeregate function in Django. You can read more about it in their documentation.
average_rating = RatingOfBook.objects.filter(book__pk=book_id).aggregate(Avg('rating'))['rating__avg']
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSoC Task 2 Submission
I have completed the following tasks