Introduce verbose flag to disable debug statement leading to large log files. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer to have a flag to disable the printout (default should be to print) instead of just turning it off since this warning (see #63) can potentially lead to wrong results |
|
True. I will add some debug flag as an option to the EDAnalyzer. |
Conflicts: HGCalAnalysis/plugins/HGCalAnalysis.cc
|
I added the flag and only used it to toggle the debug line I was referring to initially, as the other Also, the producer has no |
clelange
suggested changes
Aug 5, 2019
There was a problem hiding this comment.
Thanks, I think the flag needs to be added to the example configuration as well?
clelange
approved these changes
Aug 5, 2019
clelange
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a trivial PR that comments two debug outputs that lead to overly large log files (~O(10MB) when creating ~O(100) events with 5 showers each).
Using the
MessageLoggerwould be the optimal solution, but this little adjustment is already helpful for now.