istream/Chunked: copy the "fallback" flag in _FillBucketList()

Fixes stalled transfer because the HTTP server library never tried to call Istream::Read().
CM4all · Aug 16, 2023 · e03ef8a · e03ef8a
1 parent 14d1d72
commit e03ef8a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/debian/changelog b/debian/changelog
@@ -2,6 +2,7 @@ cm4all-beng-proxy (18.0.31) unstable; urgency=low
 
   * io_uring: fix endless loop (18.0.30 regression)
   * io_uring: re-enable sendfile() (18.0.30 regression)
+  * http: fix stalled chunk transfer
 
  --   
 

diff --git a/src/istream/ChunkedIstream.cxx b/src/istream/ChunkedIstream.cxx
@@ -361,8 +361,12 @@ ChunkedIstream::_FillBucketList(IstreamBucketList &list)
 						       missing_from_current_chunk);
 		if (nbytes >= missing_from_current_chunk)
 			list.Push(AsBytes(list.HasMore() ? "\r\n"sv : "\r\n0\r\n\r\n"sv));
-	} else
+	} else {
 		list.SetMore();
+
+		if (sub.ShouldFallback())
+			list.EnableFallback();
+	}
 }
 
 Istream::ConsumeBucketResult