widget/Registry: free the TranslateResponse, fixing more UAF bugs

See commit acda233
CM4all · Sep 2, 2024 · 2dbae8e · 2dbae8e
1 parent 5c8ce9d
commit 2dbae8e
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/widget/Registry.cxx b/src/widget/Registry.cxx
@@ -66,6 +66,7 @@ WidgetRegistryLookup::OnTranslateResponse(UniquePoolPtr<TranslateResponse> _resp
 	assert(!response.views.empty());
 
 	if (response.status != HttpStatus{}) {
+		_response.reset();
 		callback(nullptr);
 		return;
 	}
@@ -90,6 +91,8 @@ WidgetRegistryLookup::OnTranslateResponse(UniquePoolPtr<TranslateResponse> _resp
 	cls->dump_headers = response.dump_headers;
 	cls->views = Clone(widget_pool, response.views);
 
+	_response.reset();
+
 	cache.Put(name, *cls);
 
 	callback(cls);