Merge pull request #66 from CIRA-Pulsars-and-Transients-Group/dev/chris

Tidied up cu_invert_pfb inputs
CIRA-Pulsars-and-Transients-Group · Dec 6, 2024 · 726fd8e · 726fd8e
2 parents 6fcc7e4 + 7dc14b3
commit 726fd8e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/app/make_mwa_tied_array_beam.c b/app/make_mwa_tied_array_beam.c
@@ -284,8 +284,7 @@ int main(int argc, char **argv)
 
             // Run the iPFB kernel
             cu_invert_pfb( data_buffer_fine, timestep_idx, vm->npointing,
-                    nsamples, nchans, npols, vm->vf->sizeof_buffer,
-                    &gi, data_buffer_vdif );
+                    nsamples, nchans, npols, &gi, data_buffer_vdif );
 
             logger_stop_stopwatch( vm->log, "ipfb" );
         }

diff --git a/include/vcsbeam.h.in b/include/vcsbeam.h.in
@@ -968,8 +968,8 @@ extern "C" {
 #endif
 
 void cu_invert_pfb( gpuDoubleComplex *data_buffer_fine, int file_no,
-                        int npointing, int nsamples, int nchan, int npol, int sizeof_buffer,
-                        struct gpu_ipfb_arrays *g, float *data_buffer_uvdif );
+                        int npointing, int nsamples, int nchan, int npol,
+                        struct gpu_ipfb_arrays *g, float *data_buffer_vdif );
 
 void cu_load_ipfb_filter( pfb_filter *filter, struct gpu_ipfb_arrays *g );
 

diff --git a/src/pfb.cpp b/src/pfb.cpp
@@ -910,6 +910,15 @@ __global__ void ipfb_kernel(
 /**
  * Invert the PFB by applying a resynthesis filter, using GPU acceleration.
  *
+ * @param[in]   data_buffer_fine The fine-channelised voltages
+ * @param       file_no An index corresponding to the second of the data
+ * @param       npointing The number of pointings
+ * @param       nsamples The number of time samples per second of input data
+ * @param       nchan The number of fine channels
+ * @param       npol The number of instrumental polarisations
+ * @param       g The ipfb filter struct
+ * @param[out]  data_buffer_vdif The reconstructed coarse-channelised voltages
+ *
  * This function expects `data_buffer_fine` to be a 1D array of complex
  * voltages with indices following the ordering:
  *
@@ -939,7 +948,6 @@ __global__ void ipfb_kernel(
  */
 void cu_invert_pfb( gpuDoubleComplex *data_buffer_fine, int file_no,
                         int npointing, int nsamples, int nchan, int npol,
-                        int sizeof_buffer,
                         struct gpu_ipfb_arrays *g, float *data_buffer_vdif )
 {
     // Setup input values: