Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolyPen knife does not cut if there is a selection #1368

Closed
jlampel opened this issue Dec 9, 2024 · 2 comments
Closed

PolyPen knife does not cut if there is a selection #1368

jlampel opened this issue Dec 9, 2024 · 2 comments
Milestone

Comments

@jlampel
Copy link
Member

jlampel commented Dec 9, 2024

PolyPen's knife works great if no verts or edges are selected but does not work if there is an edge selected.

It feels intuitive to select an edge before making a cut, and even though that's not necessary I think it should still be supported.

Really any time the mouse is over a face, it should cut instead of add geometry. There is no case that I can think of where we would want overlapping geometry while retopologizing, so I think it's a safe assumption that would make for a big workflow enhancement.

image

But there's also not really a scenario where I'd want to make a face that has almost 0 area. Can there also be a rule that if the area of a face is under a certain threshold or the point is within a certain distance from an edge, it instead makes a cut?

image

@vxlcoder
Copy link
Contributor

the main issue should now be fixed and ready for testing.

will still need to work through handling the non-overlapping geometry.

also, PP does not handle having an edge selected and then clicking on an edge or vert that shares a face with selected edge. this should probably cut the face, but I'm not fully sure what makes the most sense when hovering an edge. created issue #1407 to track this.

@jlampel
Copy link
Member Author

jlampel commented Jan 13, 2025

Awesome, this does solve the main problem. I really like the way the visualization snaps to the selected edge when the mouse is close 👏

@jlampel jlampel closed this as completed Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants