Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolyPen is very slow if many components are selected #1369

Closed
jlampel opened this issue Dec 9, 2024 · 2 comments
Closed

PolyPen is very slow if many components are selected #1369

jlampel opened this issue Dec 9, 2024 · 2 comments

Comments

@jlampel
Copy link
Member

jlampel commented Dec 9, 2024

PolyPen really struggles if a lot of components are selected, like in the example below.

image

This is probably from iterating over all possible edges on every mouse update to find the best connection. While this isn't something we would encourage users to do and not something we need to explicitly support, there are two things I think we could do to help speed this up so that RF doesn't come to a crawl if a user does this accidentally on a large mesh.

  1. We could eliminate any interior verts from the calculation and only look at the boundary loop, since we can assume we don't want to draw a face on top of another face.

  2. When the mouse is over a face or right next to an edge, we could assume that the user wants to make a cut instead and not evaluate the connection points at all.

Related to: #1368

@vxlcoder vxlcoder self-assigned this Jan 11, 2025
@vxlcoder
Copy link
Contributor

i don't think the slowness is an issue anymore. or, at least I am unable to reproduce it. is this still an issue for you, @jlampel?

we could still eliminate interior (manifold) edges from consideration in creating new faces.

@jlampel
Copy link
Member Author

jlampel commented Jan 13, 2025

This is lightning fast now! Not sure which change did it, but it's fixed!

@jlampel jlampel closed this as completed Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants