Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove QT_NO_KEYWORDS from CGAL::CGAL_Basic_viewer #8581

Merged
merged 1 commit into from
Nov 8, 2024
Merged

remove QT_NO_KEYWORDS from CGAL::CGAL_Basic_viewer #8581

merged 1 commit into from
Nov 8, 2024

Conversation

lrineau
Copy link
Member

@lrineau lrineau commented Oct 29, 2024

Summary of Changes

Fix #8574.

Release Management

  • Affected package(s): CGAL, CMake scripts
  • Issue(s) solved (if any): fix #0000, fix #0000,...
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership:

@sloriot
Copy link
Member

sloriot commented Nov 8, 2024

Successfully tested in CGAL 6.1-Ic-14

@lrineau lrineau changed the base branch from master to 6.0.x-branch November 8, 2024 15:14
@lrineau lrineau changed the base branch from 6.0.x-branch to master November 8, 2024 15:14
@lrineau lrineau added this to the 6.0.2 milestone Nov 8, 2024
@sloriot sloriot changed the base branch from master to 6.0.x-branch November 8, 2024 15:17
@sloriot sloriot merged commit 400acfb into CGAL:6.0.x-branch Nov 8, 2024
9 checks passed
@sloriot sloriot deleted the CGAL-fix_QT_NO_KEYWORDS-GF branch November 8, 2024 15:17
@github-actions github-actions bot removed the Tested label Nov 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@sloriot sloriot added the Tested label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug CMake scripts Tested
Projects
None yet
Milestone
6.0.2
Development

Successfully merging this pull request may close these issues.

CGAL::CGAL_Basic_viewer enforces the definition of the preprocessor macro QT_NO_KEYWORDS
2 participants
@lrineau @sloriot