-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lab - add polylines to selection of edges #8411
Open
janetournois
wants to merge
14
commits into
CGAL:master
Choose a base branch
from
janetournois:Lab-polyline_features-jtournois
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lab - add polylines to selection of edges #8411
janetournois
wants to merge
14
commits into
CGAL:master
from
janetournois:Lab-polyline_features-jtournois
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afabri
reviewed
Sep 17, 2024
...esh_processing/include/CGAL/Polygon_mesh_processing/internal/Corefinement/face_graph_utils.h
Show resolved
Hide resolved
janetournois
force-pushed
the
Lab-polyline_features-jtournois
branch
from
October 1, 2024 12:51
0d1ecbe
to
95be09a
Compare
I guess the warning in I-c-351 comes from this PR. @janetournois can you check if the plugin does what you want to achieve. |
sloriot
reviewed
Oct 18, 2024
one clip case is not correctly handled yet
…nd constrain_intersection_edges
sloriot
added
Not yet approved
The feature or pull-request has not yet been approved.
Pkg::PMP
labels
Oct 31, 2024
janetournois
force-pushed
the
Lab-polyline_features-jtournois
branch
from
November 4, 2024 13:05
0f6d5f8
to
4654b7e
Compare
janetournois
force-pushed
the
Lab-polyline_features-jtournois
branch
from
November 4, 2024 13:19
4654b7e
to
9030df6
Compare
Successfully tested in CGAL-6.1-Ic-14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CGAL 3D demo
Not yet approved
The feature or pull-request has not yet been approved.
Pkg::PMP
Tested
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
With this PR
Release Management