Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab - add polylines to selection of edges #8411

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

janetournois
Copy link
Member

Summary of Changes

With this PR

  • load a surface triangle mesh
  • load a set of polylines (*.polylines.txt, or *.cgal, or *.txt)
  • create a selection item containing the polylines as selected edges (in PMP -> Select edges)

Release Management

  • Affected package(s): CGAL lab
  • License and copyright ownership: unchanged

@janetournois janetournois added this to the 6.1-beta milestone Aug 13, 2024
@janetournois janetournois force-pushed the Lab-polyline_features-jtournois branch from 0d1ecbe to 95be09a Compare October 1, 2024 12:51
@afabri
Copy link
Member

afabri commented Oct 15, 2024

Warnings in I-c-348, but I think it is to early for the testsuite as there are todos in the code and lots of debug std::cout, which is normal as this is only a draft PR @sloriot

@afabri
Copy link
Member

afabri commented Oct 18, 2024

I guess the warning in I-c-351 comes from this PR.

@janetournois can you check if the plugin does what you want to achieve.
I can then throw out debug code and output.

@janetournois janetournois marked this pull request as ready for review October 18, 2024 08:55
@sloriot sloriot added Not yet approved The feature or pull-request has not yet been approved. Pkg::PMP labels Oct 31, 2024
@janetournois janetournois force-pushed the Lab-polyline_features-jtournois branch from 0f6d5f8 to 4654b7e Compare November 4, 2024 13:05
@janetournois janetournois force-pushed the Lab-polyline_features-jtournois branch from 4654b7e to 9030df6 Compare November 4, 2024 13:19
@sloriot
Copy link
Member

sloriot commented Nov 8, 2024

Successfully tested in CGAL-6.1-Ic-14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CGAL 3D demo Not yet approved The feature or pull-request has not yet been approved. Pkg::PMP Tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants