Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AoS_2, earth demo: find_package(nlohmann_json...) must be QUIET #8220

Merged
merged 1 commit into from
May 26, 2024
Merged

AoS_2, earth demo: find_package(nlohmann_json...) must be QUIET #8220

merged 1 commit into from
May 26, 2024

Conversation

lrineau
Copy link
Member

@lrineau lrineau commented May 23, 2024

Summary of Changes

Fix after #7678 was merge in master. There was an worrying CMake warning.

Release Management

  • Affected package(s): Arr_2

@lrineau lrineau added CMake scripts Warnings For an issue about warnings, or a pull-request that fixes warnings labels May 23, 2024
@lrineau lrineau added this to the 6.0-beta milestone May 23, 2024
@lrineau lrineau added the Batch_1 First Batch of PRs under testing label May 23, 2024
@lrineau lrineau requested a review from afabri May 23, 2024 16:30
@lrineau lrineau added the rm only: release blocker For the release team only: the next release requires this issue/PR to be solved/merge label May 23, 2024
@lrineau lrineau requested a review from efifogel May 23, 2024 16:35
afabri
afabri approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@afabri afabri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. The Problem reported in vscode is gone.

@sloriot sloriot added Under Testing and removed Batch_1 First Batch of PRs under testing labels May 24, 2024
@sloriot
Copy link
Member

sloriot commented May 26, 2024

Successfully tested in 6.0-Ic-251

@sloriot sloriot merged commit 678ae19 into CGAL:master May 26, 2024
8 checks passed
@sloriot sloriot deleted the AoS_2_demo_earth-fix_CMake-GF branch May 26, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afabri afabri afabri approved these changes

@efifogel efifogel Awaiting requested review from efifogel

Assignees
No one assigned
Labels
CMake scripts Merged_in_6.0 rm only: release blocker For the release team only: the next release requires this issue/PR to be solved/merge Tested Warnings For an issue about warnings, or a pull-request that fixes warnings
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@lrineau @sloriot @afabri