Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinetic Surface Reconstruction #7908

Merged

Conversation

soesau
Copy link
Member

@soesau soesau commented Dec 5, 2023

Kinetic Surface Reconstruction

Complementing the Kinetic Shape Partition package with the reconstruction pipeline described in the original paper.

  • Affected package(s): Kinetic Shape Partitioning and Kinetic Surface Reconstruction
  • Issue(s) solved (if any):
  • Feature/Small Feature (if any):
  • Link to compiled documentation: doc
  • License and copyright ownership: GeometryFactory/Inria

link to mirrored PR

soesau and others added 4 commits May 15, 2024 16:45
@sloriot sloriot force-pushed the Kinetic_surface_reconstruction-new_package-soesau branch from acff6ac to d69642c Compare May 15, 2024 15:58
@github-actions github-actions bot removed the Tested label May 15, 2024
Copy link

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@sloriot sloriot added Under Testing depends on another PR This pull-request should only be merged after other ones. labels May 15, 2024
@soesau
Copy link
Member Author

soesau commented May 21, 2024

/build:v0

Copy link

There was an error while building the doc:

This round already exists. Overwrite it with /force-build.

https://github.com/CGAL/cgal/actions/runs/9170499335

@soesau
Copy link
Member Author

soesau commented May 21, 2024

/force-build:v0

Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7908/v0/Manual/index.html

@lrineau lrineau added the rm only: release blocker For the release team only: the next release requires this issue/PR to be solved/merge label May 21, 2024
@soesau
Copy link
Member Author

soesau commented May 24, 2024

/force-build:v0

Comment on lines +62 to +68

*/

\section Ksp_history Design and Implementation History

This package is an implementation of Bauchet et. al \cgalCite{bauchet2020kinetic}.
A proof of concept of the kinetic partition was developed by Simon Giraudot and Dmitry Anisimov.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look good, in #7198 it looks better but it might be the cause of the warning

/home/cgal-testsuite/cgal_doc_build/CGAL-6.0-Ic-250/doc/scripts/doc_1_9_6/doc_tags/Kinetic_surface_reconstruction.tag:179: warning: Duplicate anchor Ksp_history found

in the overnight documentation build.
(Might be fixed by a recent commit but is hard to tell due to the size and number of commits of both the packages)

Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7908/v0/Manual/index.html

@sloriot
Copy link
Member

sloriot commented May 26, 2024

Successfully tested in CGAL-6.0-Ic-251

@sloriot sloriot merged commit 61decad into CGAL:master May 26, 2024
9 checks passed
@MaelRL
Copy link
Member

MaelRL commented May 26, 2024

CHANGES.md wasn't updated.

Please do it in #8226.

@lrineau lrineau added this to the 6.0-beta milestone Jun 7, 2024
@sloriot sloriot deleted the Kinetic_surface_reconstruction-new_package-soesau branch October 14, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted feature depends on another PR This pull-request should only be merged after other ones. Feature Merged_in_6.0 rm only: release blocker For the release team only: the next release requires this issue/PR to be solved/merge Tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants