Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix general_polygon_example.png #7728

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

lbartoletti
Copy link
Contributor

Summary of Changes

The visibility zone is slightly offset on the original image. This version displays the correct zone.

Before:

image

After:

image

Release Management

  • Affected package(s):
  • Issue(s) solved (if any): fix #0000, fix #0000,...
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership:

@lrineau
Copy link
Member

lrineau commented Sep 22, 2023

@lbartoletti There is an issue with your commit: it is empty.

The visibility zone is slightly offset on the original image. This version displays the correct zone.
@lbartoletti
Copy link
Contributor Author

@lbartoletti There is an issue with your commit: it is empty.

Ooops. Fixed.

@afabri
Copy link
Member

afabri commented Sep 25, 2023

In case you use a vector graphics tool for producing the image it would be preferable that you commit a svg version.

@sloriot sloriot added the Batch_2 Second Batch of PRs under testing label Oct 16, 2023
@sloriot sloriot added Batch_1 First Batch of PRs under testing Under Testing and removed Batch_2 Second Batch of PRs under testing Batch_1 First Batch of PRs under testing labels Oct 31, 2023
@sloriot
Copy link
Member

sloriot commented Nov 15, 2023

Successfully tested in CGAL-6.0-Ic-106

@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Nov 15, 2023
@lrineau lrineau self-assigned this Nov 15, 2023
@lrineau lrineau added this to the 6.0-beta milestone Nov 15, 2023
@lrineau lrineau merged commit 03657c9 into CGAL:master Nov 15, 2023
9 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Nov 15, 2023
@lbartoletti lbartoletti deleted the fix_general_polygon_example_fig branch October 2, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants