Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box_intersection_d: Fix doc link #7717

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

afabri
Copy link
Member

@afabri afabri commented Sep 17, 2023

Summary of Changes

Add docgroup for enum.

Release Management

@@ -2,6 +2,9 @@
/// \defgroup PkgBoxIntersectionDConcepts Concepts
/// \ingroup PkgBoxIntersectionDRef

/// \defgroup PkgBoxIntersectionDEnums Rnumerations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rnumerations -> Enumerations

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stupid me.
I am also wondering if we do not have to add a \cgalCRPSection{Enumerations}. Do we have a canonical order for those? In Arrangements the enums come before the concepts.

Copy link
Contributor

@albert-github albert-github Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you mean with canonical something like cgalEnumerations I don't think so. A grep over BaseDoxyfile.in for cgalCRPSection just gave cgalCRPSection{1}=<h2>\1</h2>.
There are quite a few usages of cgalCRPSection though and when just looking for enumeration types I found the usages:

  • Enum
  • Enums
  • Enumerations
  • Constants and Enumerations

This cannot be correct (I think):

Arrangement_on_surface_2/doc/Arrangement_on_surface_2/PackageDescription.txt:\cgalCRPSection{Enumerations}
Circular_kernel_3/doc/Circular_kernel_3/PackageDescription.txt:\cgalCRPSection{Constants and Enumerations}
Cone_spanners_2/doc/Cone_spanners_2/PackageDescription.txt:\cgalCRPSection{Enumerations}
Kernel_23/doc/Kernel_23/PackageDescription.txt:\cgalCRPSection{Constants and Enumerations}
Mesh_2/doc/Mesh_2/PackageDescription.txt:\cgalCRPSection{Enumerations}
Mesh_3/doc/Mesh_3/PackageDescription.txt:\cgalCRPSection{Enumerations}
Periodic_2_triangulation_2/doc/Periodic_2_triangulation_2/PackageDescription.txt:\cgalCRPSection{Enums}
Periodic_3_triangulation_3/doc/Periodic_3_triangulation_3/PackageDescription.txt:\cgalCRPSection{Enums}
Ridges_3/doc/Ridges_3/PackageDescription.txt:\cgalCRPSection{Enums}
Stream_support/doc/Stream_support/PackageDescription.txt:\cgalCRPSection{Enum}
Surface_mesh_shortest_path/doc/Surface_mesh_shortest_path/PackageDescription.txt:\cgalCRPSection{Enums}
Triangulation/doc/Triangulation/PackageDescription.txt:\cgalCRPSection{Enums}
Triangulation_2/doc/Triangulation_2/PackageDescription.txt:\cgalCRPSection{Enum}
Triangulation_3/doc/Triangulation_3/PackageDescription.txt:\cgalCRPSection{Enums}
Triangulation_on_sphere_2/doc/Triangulation_on_sphere_2/PackageDescription.txt:\cgalCRPSection{Enum}

In all there I quickly found 391 usages of cgalCRPSection with 168 unique values, I used (a.o.):

grep cgalCRPSection -r [A-Z]* | grep -v "Documentation"  | sed -e "s/[^:]*://" | sort | uniq

and see that there are more catagories with "double" names (see e.g. Traits...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was more wondering about the order of the sections
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order is something doxygen cannot enforce and has to be done by means of "coding standards" and can be checked by part the "grep" I gave (i.e. the part: grep cgalCRPSection -r [A-Z]* | grep -v "Documentation") and checking whether or not the order is OK (script).

@sloriot
Copy link
Member

sloriot commented Oct 15, 2023

Successfully tested in CGAL-6.0-Ic-84

@lrineau lrineau self-assigned this Oct 16, 2023
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Oct 16, 2023
@lrineau lrineau merged commit 0821ea3 into CGAL:master Oct 16, 2023
9 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Oct 16, 2023
@lrineau lrineau deleted the Box_intersection_d-doc_enum-GF branch October 16, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Box_intersection_d: unknown group in documentation
4 participants