Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct size() in case some points were removed #7686

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Correct size() in case some points were removed #7686

merged 1 commit into from
Sep 7, 2023

Conversation

sloriot
Copy link
Member

@sloriot sloriot commented Sep 4, 2023 •
edited
Loading

Fixes #7676

alternative fix to #7685

With this fix, size() stays O(1)

@lrineau lrineau added this to the 5.5.4 milestone Sep 4, 2023
@lrineau lrineau linked an issue Sep 4, 2023 that may be closed by this pull request
The tree size of a kd tree didn't update after removal of points. #7676
Closed
@sloriot
Copy link
Member Author

sloriot commented Sep 6, 2023

Successfully tested in CGAL-6.0-Ic-56

@lrineau lrineau self-assigned this Sep 6, 2023
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Sep 6, 2023
@lrineau lrineau mentioned this pull request Sep 6, 2023
Closed
@lrineau lrineau added the rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch label Sep 6, 2023
lrineau added a commit that referenced this pull request Sep 7, 2023
@lrineau
Merge pull request #7686 from sloriot/SS-fix_size_after_remove
e8d8197 
Correct size() in case some points were removed
lrineau added a commit that referenced this pull request Sep 7, 2023
@lrineau
Merge pull request #7686 from sloriot/SS-fix_size_after_remove
7cd107a 
Correct size() in case some points were removed
@lrineau lrineau merged commit 661e065 into CGAL:5.5.x-branch Sep 7, 2023
7 checks passed
@lrineau lrineau removed rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' labels Sep 7, 2023
@lrineau lrineau deleted the SS-fix_size_after_remove branch September 7, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lrineau lrineau

Labels
Bug Merged_in_5.5.4 Merged_in_5.5.5 Merged_in_5.6.1 Merged_in_5.6.2 Merged_in_6.0 Pkg::Spatial_searching Tested
Projects
None yet
Milestone
5.5.4
Development

Successfully merging this pull request may close these issues.

The tree size of a kd tree didn't update after removal of points.
2 participants
@sloriot @lrineau