Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more permissive in Compare_dihedral_angle_3 #7650

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Be more permissive in Compare_dihedral_angle_3 #7650

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73cf624
be more permessive
sloriot Aug 16, 2023
f879c68
Test earlier
sloriot Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Kernel_23/include/CGAL/Kernel/function_objects.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ namespace CommonKernelFunctors {

const Vector_3 abac1 = xproduct(ab1, ac1);
const Vector_3 abad1 = xproduct(ab1, ad1);
if (abac1==NULL_VECTOR || abad1==NULL_VECTOR) return SMALLER;
sloriot marked this conversation as resolved.
Show resolved Hide resolved
const FT sc_prod_1 = abac1 * abad1;

CGAL_kernel_assertion_msg( abac1 != NULL_VECTOR,
Expand Down