Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgal_create_release_with_cmake.cmake: only call Git one #7628

Conversation

lrineau
Copy link
Member

@lrineau lrineau commented Aug 1, 2023

Summary of Changes

cgal_create_release_with_cmake.cmake was terribly slow (in particular on Windows). In order to fix that:

  • call Git only once, to get the Git hash of the repository, and
  • Use $Id: ${f} ${GIT_HASH} $ to replace $Id$ (all files have the same hash).

That is sufficient to identify without any doubt the version is the original file.

@sloriot: do you agree with those changes?

Release Management

  • Affected package(s): Scripts

Cc: @janetournois

@lrineau
Copy link
Member Author

lrineau commented Aug 1, 2023

On my Linux machine, the difference is:

  • 65 seconds before, versus
  • 1.2 seconds now.

@sloriot
Copy link
Member

sloriot commented Aug 24, 2023

Successfully tested in CGAL-6.0-Ic-46 (provided it is used by scripts)

@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Aug 28, 2023
@lrineau lrineau merged commit 603d2b2 into CGAL:master Aug 28, 2023
8 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Aug 28, 2023
@lrineau lrineau deleted the Scripts-fix_cgal_create_release_with_cmake.cmake-GF branch August 28, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants