Add CGAL/version_checker.h
#7528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janetournois
force-pushed
the
CGAL-add_version_enforcer-jtournois
branch
from
c22eb19
to
522183b
Compare
sloriot
added
the
Not yet approved
the 3 major/minor/patch are needed to compare integrals if they are defined, the version check is done and warning or error are displayed
sloriot
added
Under Testing
Batch_2
|
Successfully tested in CGAL-6.0-Ic-20 |
sloriot
reviewed
Jul 12, 2023
…e" version after review
|
This pull-request was previously marked with the label |
lrineau
removed
the
Not yet approved
lrineau
added
Not yet approved
|
This PR has the milestone CGAL-5.6 but its base branch is |
|
If there are more things to be merged to 5.6, it can be merged there. Otherwise I can wait for the next release, no worries |
|
Successfully tested in CGAL-6.0-Ic-33 |
sloriot
removed
the
Not yet approved
sloriot
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Following discussion #7525 I added the header
version_enforcer.hIn the general case, it has nothing to check. If the user includes his own fork of
version_enforcer.hwith a given number of CGAL version, then the check happens.Release Management