Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge insertion for CMap/GMap #7409

Merged
merged 30 commits into from
Aug 14, 2023
Merged

Conversation

gdamiand
Copy link
Member

Please use the following template to help us managing pull requests.

Summary of Changes

Added the function insert_cell_1_between_two_cells_2() into GenericMap concept, which allows users to insert an edge between two different faces allowing to create faces with holes.

Release Management

@gdamiand
Copy link
Member Author

/force-build:v1

@github-actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7409/v1/Manual/index.html

@MaelRL MaelRL added this to the 6.0-beta milestone Apr 28, 2023
@MaelRL MaelRL added Not yet approved The feature or pull-request has not yet been approved. Small feature Pkg::Combinatorial_map labels Apr 28, 2023
@gdamiand
Copy link
Member Author

/force-build:v2

@github-actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7409/v2/Manual/index.html

@sloriot sloriot added Under Testing Batch_2 Second Batch of PRs under testing and removed Under Testing labels Jun 7, 2023
@sloriot sloriot added the Tested label Jun 14, 2023
@gdamiand
Copy link
Member Author

/force-build:v2

@github-actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7409/v2/Manual/index.html

sloriot added a commit to sloriot/cgal that referenced this pull request Jun 22, 2023
@gdamiand
Copy link
Member Author

/force-build:v3

@github-actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7409/v3/Manual/index.html

@afabri afabri added pre-approved For pre-approved small features. After 15 days the feature will be accepted. and removed Not yet approved The feature or pull-request has not yet been approved. labels Jun 26, 2023
@sloriot sloriot added Batch_1 First Batch of PRs under testing Under Testing and removed Under Testing labels Jun 28, 2023
@sloriot
Copy link
Member

sloriot commented Jul 5, 2023

Successfully tested in CGAL-6.0-Ic-15

@sloriot sloriot added Tested and removed Under Testing Batch_1 First Batch of PRs under testing labels Jul 5, 2023
@sloriot sloriot added Accepted small feature and removed pre-approved For pre-approved small features. After 15 days the feature will be accepted. labels Aug 14, 2023
@sloriot sloriot merged commit c5cf3d9 into CGAL:master Aug 14, 2023
@sloriot sloriot deleted the CMap-insert-gdamiand branch August 14, 2023 09:55
@sloriot sloriot self-assigned this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants