Isosurfacing_3 (new package) #6849

JulyCode · 2022-09-15T09:42:39Z

Summary of Changes

Extracting isosurfaces from scalar functions is a common method for generating 3D meshes. An isosurface is a subspace with equal values of the function.

ToDo:

Give feedback

Check branch size
TMC_functor::compute_edge_index() uses operator[] on cell_descriptor (violates concept)
Check Orthtree as partition for Marching Cubes after fixing compute_edge_index()
Options

Extra:

Give feedback

Use Isosurfacing_3 in the demo (Isosurface_3_plugin)
Options

Release Management

Affected package(s): Isosurfacing_3
Issue(s) solved (if any): -
Feature/Small Feature (if any): Isosurfacing_3
License and copyright ownership: see feature

Isosurfacing_3/doc/Isosurfacing_3/Concepts/IsosurfacingDomain.h

Isosurfacing_3/include/CGAL/Cartesian_topology_base.h

Isosurfacing_3/include/CGAL/Cell_type.h

Isosurfacing_3/include/CGAL/Default_gradients.h

Isosurfacing_3/include/CGAL/Dual_contouring_3.h

Isosurfacing_3/include/CGAL/Implicit_domain.h

Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/Dual_contouring_internal.h

Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/Marching_cubes_3_internal.h

Isosurfacing_3/include/CGAL/Marching_cubes_3.h

Isosurfacing_3/include/CGAL/Octree_domain.h

Isosurfacing_3/examples/Isosurfacing_3/marching_cubes_inrimage.cpp

Isosurfacing_3/include/CGAL/Octree_wrapper.h

Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/Dual_contouring_internal.h

afabri · 2022-09-15T12:15:30Z

/build:v1

github-actions · 2022-09-15T12:28:31Z

There was an error while building the doc:
/home/runner/work/cgal/cgal/Isosurfacing_3/include/CGAL/Octree_wrapper.h:330: warning: The following parameters of CGAL::Isosurfacing::Octree_wrapper::e_glIndex(const std::size_t &e, const std::size_t &i_idx, const std::size_t &j_idx, const std::size_t &k_idx, const std::size_t &depth) const are not documented:

afabri · 2022-09-15T13:04:34Z

The data files have a problem with rights. I think they also need o+r
But more importantly they should be in the package Data so that we do not have millions of bunnies and skulls.

MaelRL · 2024-10-04T10:05:41Z

Where do all these changes i'th to i-th come from in dozens of files which have nothing to do with iso surfacing ?

efc43a6

github-actions · 2024-10-09T14:44:08Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/6849/current/Manual/index.html

sloriot · 2024-10-10T09:41:39Z

Isosurfacing_3/examples/Isosurfacing_3/contouring_vtk_image.cpp

+  const char* filename = fname.c_str();
+  const FT isovalue = (argc > 2) ? std::stod(argv[2]) : 3;
+
+  const std::string ext = CGAL::IO::internal::get_file_extension(filename);


you should use something from the STL

Isosurfacing_3/examples/Isosurfacing_3/CMakeLists.txt

sloriot · 2024-10-14T07:32:14Z

Successfully tested in CGAL-6.0.1-Ic-345

lrineau · 2024-10-14T09:11:33Z

@afabri You requested change (negative review0; a few months ago: #6849 (review).

Can you please re-review, if you now agree with the changes, so that the red flag on the PR disappears?

lrineau · 2024-10-14T09:12:40Z

@soesau Can you please merge master and fix the conflict in the file Orthtree/include/CGAL/Orthtree.h?

github-actions · 2024-10-14T12:43:05Z

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

This comment was marked as outdated.

Sign in to view