Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluids: Update MatCeed to be up-to-date with HONEE and Ratel #1703

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

jrwrigh
Copy link
Collaborator

@jrwrigh jrwrigh commented Oct 23, 2024

Update's MatCeed in the fluids example to be up to date with HONEE and Ratel.

Note this requires Noether's PETSc install to be updated to reflect the changes in PETSc MRs !7900 and !7960.

@jeremylt
Copy link
Member

We still don't have a fix for the CUDA issue with fluids, yes? I can rebuild all the CI PETSc in the morning

@jrwrigh
Copy link
Collaborator Author

jrwrigh commented Oct 24, 2024

Yeah, still no fix to the CUDA fluids issue. At least not that I've tested. Should probably make a PETSc issue for that, just so it's a known regression/change of behavior.

@KennethEJansen
Copy link
Collaborator

While I am a strong advocate of getting this reviewed, it touches a lot of code I have very little experience with so I think this is an @jedbrown or @jeremylt review.
I see mention of a CUDA issue. I can offer up that all the Polaris tests I posted on ALCF-CNDA with a date of 241023 PETSc were with this branch since main would not exit cleanly there. The results were not run through a formal comparison but convergence and performance appeared to be correct.

@jedbrown jedbrown merged commit bef6543 into main Oct 27, 2024
28 checks passed
@jedbrown jedbrown deleted the jrwrigh/update_matceed branch October 27, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants