-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Un-skip E2E test: idletimeout.spec.ts if needed #16402
base: master
Are you sure you want to change the base?
Un-skip E2E test: idletimeout.spec.ts if needed #16402
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Branch deployed to Chromatic 🚀.
View via: |
Quality Gate passedIssues Measures |
|
// Add/Sub 500 ms to account for variance | ||
const timeoutLow = timeout - 500; | ||
const timeoutHigh = timeout + 500; | ||
const timeout = parseInt(process.env.VITE_IDLE_TIMEOUT ?? "900000"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we make the "900000"
an integer?
@@ -37,27 +36,28 @@ const test = baseTest.extend<OrganizationPageFixtures>({ | |||
frontendWarningsLogPath, | |||
isFrontendWarningsLog, | |||
}); | |||
await page.page.clock.install(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how time is persisted in these tests, but is it worth cleaning up afterwards like so:
test.afterEach(async ({ page }) => {
await page.clock.uninstall();
});
Fixes #16060
This PR unskips the idletimeout test and adds a new one in order to test time moving forward under/over the timeout. The tests use the page.clock functions in order to artificially move time forward mimicing idle.