Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating actions-connect-ovpn GitHub Action into project #16396

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

emvaldes
Copy link
Collaborator

@emvaldes emvaldes commented Oct 30, 2024

This PR is intended to integrate the remote/external JosiahSiegel/action-connect-ovpn GitHub Action into this project.

There are no exploitable issues to address in this PR.

Test Steps:

  1. *Although We need to identify reference migration issues we do not anticipate any and it's an in-place reference to local action.

Changes

  • Adding the workflows/check_vpn.yml as its default workflow
  • Replacing remote GitHub Actions references for local references

Checklist

Testing

  • This functionality cannot be tested locally so we are skipping this step but we are memorializing it.
  • Submitting this PR to determine how viable this approach is with minimum changes to the imported GitHub Action.

Process

  • Validate that there are there no licensing issues or new dependencies introduced.
  • Reviewing any documentation and/or release notes (none is required)
  • DevSecOps team is reviewing all configurations associated with this integration effort

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints? No.
  • Does this PR include changes in authentication and/or authorization of existing endpoints? No
  • Does this change introduce new dependencies that need vetting? No
  • Does this change require changes to our infrastructure? No
  • Does logging contain sensitive data? No
  • Does this PR include or remove any sensitive information itself? No

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? No
  • Have you ensured logging does not contain sensitive data? No
  • Have you received any additional approvals needed for this change? No

@emvaldes emvaldes added tech-debt Anything that is purely a technical issue and does not affect functionality reportstream DevSecOps Team Aq DevSecOps work label labels Oct 30, 2024
@emvaldes emvaldes added this to the in progress milestone Oct 30, 2024
@emvaldes emvaldes self-assigned this Oct 30, 2024
@emvaldes emvaldes marked this pull request as ready for review October 30, 2024 04:10
@emvaldes emvaldes requested a review from a team as a code owner October 30, 2024 04:10
Copy link
Collaborator

@devopsmatt devopsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devopsmatt
Copy link
Collaborator

@emvaldes id suggest that we leave it unmerged until Friday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevSecOps Team Aq DevSecOps work label reportstream tech-debt Anything that is purely a technical issue and does not affect functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants