Add pre-commit and test workflow #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmastephenson
requested review from
nickclyde,
nickbristow,
gordonfarrell and
KennethSkylight
nickbristow
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #773.
Adds pre-commit formatting for terraform, json, .js, .tsx, and yaml (via prettier). This is also configured to automatically run on PRs (we can change if it's annoying.)
Also added a basic test workflow that for now just runs eslint; we'll add more functionality as we add tests. Once this is merged, I'll make passing it a required status check.
NOTE: I ran pre-commit on all the files already in the repo, which is why there are so many changes. The only actual changes are in
.github/workflows/test.yamland.pre-commit-config.yaml.