Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment fix #4

Merged
merged 24 commits into from
Aug 24, 2023
Merged

Deployment fix #4

merged 24 commits into from
Aug 24, 2023

Conversation

KennethSkylight
Copy link
Collaborator

@KennethSkylight KennethSkylight commented Aug 22, 2023 •
edited
Loading

All the changes needed to fix the deployment. Removed data factory e2e test. Remove storage references, decreased the node count.

It deploys the helm charts into AKS using terraform

@KennethSkylight KennethSkylight temporarily deployed to main August 22, 2023 15:25 — with GitHub Actions Inactive
@KennethSkylight KennethSkylight temporarily deployed to main August 24, 2023 17:23 — with GitHub Actions Inactive
@KennethSkylight KennethSkylight temporarily deployed to main August 24, 2023 17:30 — with GitHub Actions Inactive
@KennethSkylight KennethSkylight temporarily deployed to main August 24, 2023 17:51 — with GitHub Actions Inactive
@KennethSkylight KennethSkylight temporarily deployed to main August 24, 2023 17:52 — with GitHub Actions Inactive
@KennethSkylight KennethSkylight temporarily deployed to main August 24, 2023 17:53 — with GitHub Actions Inactive
nickclyde
nickclyde requested changes Aug 24, 2023
View reviewed changes
Copy link
Member

@nickclyde nickclyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Kenneth! Just a few notes

.github/workflows/destroy.yaml Outdated Show resolved Hide resolved
.github/workflows/end-to-end.yaml Outdated Show resolved Hide resolved
nickclyde
nickclyde approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@nickclyde nickclyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick changes! Looks great

@KennethSkylight KennethSkylight merged commit 7c1476d into main Aug 24, 2023
3 checks passed
@KennethSkylight KennethSkylight deleted the deployment_fix branch August 24, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickclyde nickclyde nickclyde approved these changes

@nickbristow nickbristow Awaiting requested review from nickbristow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KennethSkylight @nickclyde