Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: claw-compiler #72

Merged
merged 11 commits into from
Dec 4, 2019
Merged

ADD: claw-compiler #72

merged 11 commits into from
Dec 4, 2019

Conversation

elsagermann
Copy link
Contributor

@elsagermann elsagermann commented Nov 29, 2019

  1. Add the build_claw.sh script to the buildenv.

  2. Add the --package claw option to the build_apkg.sh file.

Usage:
cd buildenv/
./package_builder/build_apkg.sh --package claw -c $compiler -i <install_directory> -d <package_install_directory>

Tests:
kesch pgi: OK
kesch cray: OK
kesch gnu: OK
arolla pgi: OK
arolla gnu: OK
arolla cray: Not OK?
tsa pgi: OK
tsa gnu: OK

@elsagermann elsagermann changed the title Build claw ADD: claw-compiler Nov 29, 2019
@elsagermann elsagermann marked this pull request as ready for review November 29, 2019 11:18
@elsagermann elsagermann reopened this Nov 29, 2019
Copy link
Contributor

@lxavier lxavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the old script there was a lot of special java module and path, is this not needed anymore ?

echo "=============================="
echo "Build claw-compiler dependency: apache-ant"
if [ ! -d ${package_basedir}/hpc-scripts ] ; then
git clone [email protected]:clementval/hpc-scripts.git ${package_basedir}/hpc-scripts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably should copy this under meteowiss, I ll add a todo (no change needed for this PR)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #73

@lxavier
Copy link
Contributor

lxavier commented Dec 2, 2019

I just tried on kesch:
./package_builder/build_apkg.sh --package claw -c pgi -i ./install

I am getting an error:

./package_builder/build_claw.sh: line 99: [: ==: unary operator expected

@lxavier lxavier self-requested a review December 2, 2019 08:37
@lxavier
Copy link
Contributor

lxavier commented Dec 2, 2019

also there maybe a missing mkdir, I get another error:
"cp: cannot create regular file ‘./install/claw/pgi/modules.env’: No such file or directory"
(my install was -i ./install but install does not exist, so the scrip should create with mkdir -p $thepathrequire)

@lxavier
Copy link
Contributor

lxavier commented Dec 2, 2019

alos in the omni complier part, I see

Cloning into 'omni-compiler'...
remote: Enumerating objects: 43, done.
remote: Counting objects: 100% (43/43), done.
remote: Compressing objects: 100% (20/20), done.
remote: Total 29744 (delta 21), reused 35 (delta 15), pack-reused 29701
Receiving objects: 100% (29744/29744), 8.55 MiB | 2.29 MiB/s, done.
Resolving deltas: 100% (19997/19997), done.
Submodule path 'omni-compiler': checked out '772cf79077ac5f04cfc204fc7e0b53755a362d8b'
make: *** No targets specified and no makefile found.  Stop.
make: *** No rule to make target `install'.  Stop.

not sure if it is an issue

export claw_compiler_install=$install_path_prefix_

if [[ ! -f $claw_compiler_install/bin/clawfc || $REBUILD == YES ]]; then
if [ $REBUILD == YES ] ; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the error because REBUILD is not define, so you should give it a default in the head of your script or always check for existence

echo `pwd`
echo "Rebuilding claw-compiler"
echo "rm -r build"
rm -r build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-rf otherwise you get an error msg if build does not exist

@lxavier lxavier merged commit 8230682 into C2SM-RCM:master Dec 4, 2019
@elsagermann elsagermann deleted the build_claw branch December 5, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants