globset: add matches_all method #2900
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This returns true if all globs in the set match the supplied file. Fixes: BurntSushi#2869
|
See also rust-lang/regex#1228 |
BurntSushi
requested changes
Sep 19, 2024
crates/globset/src/lib.rs
Outdated
| @@ -351,6 +351,27 @@ impl GlobSet { | |||
| false | |||
| } | |||
|
|
|||
| /// Returns true if ALL globs in this set match the path given. | |||
There was a problem hiding this comment.
I don't think we need to use caps for ALL here. Just "all" is fine.
crates/globset/src/lib.rs
Outdated
| /// cost of peparing a path for matching. | ||
| /// | ||
| /// This will return true if the set of globs is empty, as in that case all `0` of | ||
| /// the globs will match. |
There was a problem hiding this comment.
Please wrap lines to 79 columns (inclusive).
There was a problem hiding this comment.
Also, this note should be added to matches_all too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns true if all globs in the set match the supplied file.
Fixes: #2869