Allow widget editClass to be undefined #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
Totally possible that there's a more elegant solution here, still new on the whole widget lifecycle, but this worked as a fix for me. Cheers!
PS I was also confused for a while by the name indicated at the top of the file, since I think it doesn't get used? and doesn't match the filename. Am I missing something or just a typo?
tiddlywiki-codemirror-6/tiddlywiki-codemirror-6/files/modules/subclasses/editor/edit-codemirror-6.js
Line 2 in d95260f