Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bunsenlabs-wayland.desktop #135

Merged
merged 1 commit into from
Oct 29, 2024
Merged

add bunsenlabs-wayland.desktop #135

merged 1 commit into from
Oct 29, 2024

Conversation

01micko
Copy link

@01micko 01micko commented Oct 29, 2024

add install routines for bunsenlabs-wayland.desktop and link bunsenlab-session-wayland -> bunsenlabs-session This is enough for a bunsenlabs-wayland choice in netinstall as other files can be added in the netinstall $HOME dir

@01micko
Copy link
Author

01micko commented Oct 29, 2024

@johnraff this is a start, 3 changes in one commit but all related.

It addresses #134 checks 1 and 3

@johnraff
Copy link
Member

Looks good, except that the wayland-sessions/ dir wants to be under wayland/ to keep all the wayland stuff in one place, for easier maintainance. So the line in debian/bunsen-configs-wayland.install would be wayland/wayland-sessions usr/share

In fact all the lines in debian/bunsen-configs-wayland.install will start with wayland/

@01micko
Copy link
Author

01micko commented Oct 29, 2024

Looks good, except that the wayland-sessions/ dir wants to be under wayland/ to keep all the wayland stuff in one place, for easier maintainance. So the line in debian/bunsen-configs-wayland.install would be wayland/wayland-sessions usr/share

In fact all the lines in debian/bunsen-configs-wayland.install will start with wayland/

Ok, easy fix. I'll fix the PR with a "force push". No need to worry what that is - you'll see that the PR is almost unchanged except for that detail. On it shortly.

add install routines for bunsenlabs-wayland.desktop
and link bunsenlab-session-wayland -> bunsenlabs-session
This is enough for a bunsenlabs-wayland choice in netinstall
as other files can be added in the netinstall $HOME dir
@01micko
Copy link
Author

01micko commented Oct 29, 2024

See? Fixed already :)

@johnraff
Copy link
Member

johnraff commented Oct 29, 2024

You got it!

BTW something to watch out for - at some point our symlink was named bunsenlabs-wayland-session, not bunsenlabs-session-wayland as it now is. I prefer the latter too, but our startup script bunsenlabs-session will need to be edited to reflect that.
https://github.com/BunsenLabs/bunsen-configs/blob/carbon/bin/bunsenlabs-session

For a while I was baffled why I couldn't login to Wayland...

@01micko
Copy link
Author

01micko commented Oct 29, 2024

^You're right! Well at least it's fixed now (saw your commit) so this PR should be good to go. Thanks!

@johnraff johnraff merged commit c43e5d0 into BunsenLabs:carbon Oct 29, 2024
@johnraff
Copy link
Member

Done.

@01micko
Copy link
Author

01micko commented Oct 29, 2024

Thanks!

@01micko 01micko deleted the wl0 branch October 29, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants