feat: add attribute passing for angular and stencil #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 15ff2f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 15ff2f1.
☁️ Nx Cloud last updated this comment at |
samijaber
reviewed
Jan 20, 2025
Comment on lines
14
to
28
|
|
||
| /*describe('Angular local', () => { | ||
| runTestsForTarget({ | ||
| options: { | ||
| standalone: true, | ||
| }, | ||
| target: 'angular', | ||
| generator: componentToAngular, | ||
| only: [ | ||
| // 'basicRefAttributePassing', | ||
| 'basicRefAttributePassingCustomRef' | ||
| ], | ||
| logOutput: true, | ||
| }); | ||
| });*/ |
There was a problem hiding this comment.
I see you use these for quick local testing. Will revert my removal 👍🏽
Suggested change
| /*describe('Angular local', () => { | |
| runTestsForTarget({ | |
| options: { | |
| standalone: true, | |
| }, | |
| target: 'angular', | |
| generator: componentToAngular, | |
| only: [ | |
| // 'basicRefAttributePassing', | |
| 'basicRefAttributePassingCustomRef' | |
| ], | |
| logOutput: true, | |
| }); | |
| });*/ | |
| /*describe('Angular local', () => { | |
| runTestsForTarget({ | |
| options: { | |
| standalone: true, | |
| }, | |
| target: 'angular', | |
| generator: componentToAngular, | |
| only: [ | |
| // 'basicRefAttributePassing', | |
| 'basicRefAttributePassingCustomRef' | |
| ], | |
| logOutput: true, | |
| }); | |
| });*/ |
This reverts commit 983d6b9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide the following information:
Add new feature for Angular and Stencil outputs, see this.
Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:
yarn fmt:prettier.yarn test:updateyarn g:changesetand follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.