-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for inline localized values for Builder #1659
base: main
Are you sure you want to change the base?
Conversation
|
View your CI Pipeline Execution ↗ for commit f018102.
☁️ Nx Cloud last updated this comment at |
Deploying mitosis with Cloudflare Pages
|
Description
This is a WIP PR to support inline localization for the builder parser. Next step is to add support to the generator. The idea is that when we recognize a property value as a localized value, we set the mitosis value to the
Default
and store the original localized value as a string on a$
prefixed property. Then, (not completed yet) we will take the$
prefixed values to create a localized value when converting back to Builder.Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:
yarn fmt:prettier
.yarn test:update
yarn g:changeset
and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.