Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inline localized values for Builder #1659

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

mrkoreye
Copy link
Collaborator

@mrkoreye mrkoreye commented Jan 14, 2025

Description

This is a WIP PR to support inline localization for the builder parser. Next step is to add support to the generator. The idea is that when we recognize a property value as a localized value, we set the mitosis value to the Default and store the original localized value as a string on a $ prefixed property. Then, (not completed yet) we will take the $ prefixed values to create a localized value when converting back to Builder.

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

  • format the codebase: from the root, run yarn fmt:prettier.
  • update all snapshots (in core & CLI): from the root, run yarn test:update
  • add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

Copy link

changeset-bot bot commented Jan 14, 2025

⚠️ No Changeset found

Latest commit: f018102

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Jan 14, 2025

View your CI Pipeline Execution ↗ for commit f018102.

Command Status Duration Result
nx e2e @builder.io/e2e-app ✅ Succeeded 1m 12s View ↗
nx run-many --target test ✅ Succeeded 4m 36s View ↗
nx run-many --target build --exclude @builder.i... ✅ Succeeded 3m 45s View ↗
nx build @builder.io/mitosis-site ✅ Succeeded 2m 27s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-16 23:10:23 UTC

Copy link

cloudflare-workers-and-pages bot commented Jan 16, 2025

Deploying mitosis with  Cloudflare Pages  Cloudflare Pages

Latest commit: f018102
Status: ✅  Deploy successful!
Preview URL: https://550db876.mitosis-9uh.pages.dev
Branch Preview URL: https://korey-support-localization.mitosis-9uh.pages.dev

View logs

@mrkoreye mrkoreye marked this pull request as ready for review January 16, 2025 22:55
@mrkoreye mrkoreye requested a review from samijaber as a code owner January 16, 2025 22:55
@mrkoreye mrkoreye changed the title WIP: support inline localized values for Builder Add support for inline localized values for Builder Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant