Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: angular native events vs. custom events #1657

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

nmerget
Copy link
Contributor

@nmerget nmerget commented Jan 14, 2025

Description

Please provide the following information:

angular: Generate events based on custom events (camelCase) and DOM events (lower-case).

closes #1650

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

  • format the codebase: from the root, run yarn fmt:prettier.
  • update all snapshots (in core & CLI): from the root, run yarn test:update
  • add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

@nmerget nmerget requested a review from samijaber as a code owner January 14, 2025 13:57
Copy link

nx-cloud bot commented Jan 14, 2025

View your CI Pipeline Execution ↗ for commit 2f6f4bc.

Command Status Duration Result
nx e2e @builder.io/e2e-app ✅ Succeeded 1m 9s View ↗
nx run-many --target test ✅ Succeeded 4m 45s View ↗
nx run-many --target build --exclude @builder.i... ✅ Succeeded 3m 40s View ↗
nx build @builder.io/mitosis-site ✅ Succeeded 2m 21s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-14 14:59:13 UTC

Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: bc76de5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Patch
@builder.io/mitosis-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

.changeset/polite-pugs-pull.md Outdated Show resolved Hide resolved
@samijaber samijaber enabled auto-merge (squash) January 14, 2025 14:53
@samijaber samijaber merged commit 20ad8dc into BuilderIO:main Jan 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular: lowercasing event names in data binding syntax should be optional
2 participants