Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[react-gen2]: support for variant containers #3828

Open
wants to merge 52 commits into
base: main
Choose a base branch
from

Conversation

sidmohanty11
Copy link
Contributor

@sidmohanty11 sidmohanty11 commented Jan 15, 2025

Description

Adds support for Variant Containers on Gen2 React SDK

Jira
https://builder-io.atlassian.net/browse/ENG-7676

Screenshot
If relevant, add a screenshot or two of the changes you made.

Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: 90620c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@builder.io/sdk-solid Patch
@builder.io/sdk-svelte Patch
@builder.io/sdk-vue Patch
@builder.io/sdk-angular Patch
@builder.io/sdk-react-native Patch
@builder.io/sdk-qwik Patch
@builder.io/sdk-react Patch
@builder.io/sdk-react-nextjs Patch
@builder.io/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Jan 15, 2025

View your CI Pipeline Execution ↗ for commit 90620c7.

Command Status Duration Result
nx test @e2e/qwik-city ✅ Succeeded 9m 13s View ↗
nx test @e2e/nextjs-sdk-next-app ✅ Succeeded 8m 26s View ↗
nx test @e2e/nuxt ✅ Succeeded 8m View ↗
nx test @e2e/svelte ✅ Succeeded 6m 55s View ↗
nx test @e2e/hydrogen ✅ Succeeded 6m 56s View ↗
nx test @e2e/react-sdk-next-14-app ✅ Succeeded 6m 35s View ↗
nx test @e2e/angular-16-ssr ✅ Succeeded 6m 47s View ↗
nx test @e2e/react-sdk-next-pages ✅ Succeeded 6m 31s View ↗
Additional runs (35) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-31 08:50:13 UTC

Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another bug I found: styles (probably other root-level attributes too) not applying to root VariantContainer itself: https://www.loom.com/share/8576990685a7420f8fa33cfbac9a6ce2

@sidmohanty11
Copy link
Contributor Author

@samijaber thanks for the catch again! it was for styles only, the block didn't have the builder-id in the classname so it wasn't getting applied. Have fixed this and added a test for this

Screenshot 2025-01-31 at 12 16 10 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants