-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[react-gen2]: support for variant containers #3828
base: main
Are you sure you want to change the base?
feat[react-gen2]: support for variant containers #3828
Conversation
🦋 Changeset detectedLatest commit: 90620c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
View your CI Pipeline Execution ↗ for commit 90620c7.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another bug I found: styles (probably other root-level attributes too) not applying to root VariantContainer itself: https://www.loom.com/share/8576990685a7420f8fa33cfbac9a6ce2
@samijaber thanks for the catch again! it was for styles only, the block didn't have the builder-id in the classname so it wasn't getting applied. Have fixed this and added a test for this |
Description
Adds support for Variant Containers on Gen2 React SDK
Jira
https://builder-io.atlassian.net/browse/ENG-7676
Screenshot
If relevant, add a screenshot or two of the changes you made.