Fix/client section #62
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
we want to try to match the style of these other two sections the illustration needs to nudged over to the right maybe the next and title need to be the same format as the others |
|
@austintgriffith so we get the img to be a little bit smaller and also the text right? basically we should be making at as close to the other ones as possible? |
|
|
packages/nextjs/styles/globals.css
Outdated
| @@ -1,4 +1,5 @@ | |||
| @import url("https://fonts.googleapis.com/css2?family=Space+Grotesk:wght@300;400;500;600;700&display=swap"); | |||
| @import url("https://fonts.googleapis.com/css2?family=Space+Mono:wght@400;700&display=swap"); | |||
There was a problem hiding this comment.
Is it worth it to add a new font? We already have a few fonts on the site and some inconsistencies (like the batches section)
When in doubt I'd personally try to keep the site consistent. If not, we might end up with a monstrosity after a few iterations of tweaking sections. I think Space Grotesk is fine (I'd also fix the Batches section). But we can use font-mono if we really want monospaced.
Also this monospace is only being used in one paragraph (+ is different from the nodes website!)
There was a problem hiding this comment.
Hey!
It was my idea to add the Space Mono in the beginning, cause it's very similar to the Chivo mono (original Node's font) and it's the one we're using in the Grants so it'd still be a bit consistent - but I also think keeping the Space Grotesk is fine, and now that I see it with the big title too (like other sections) it doesn't make a lot of sense to change only the paragraph's font c:
So I agree with using Space Grotesk here as in other sections, and mixing it up (in further cases) only when the overall section is much different, but also fitting in the site - like Grants section.
There was a problem hiding this comment.
So what's the verdict here :P
|
Hello! Just a little comment on the logo placement, also to be consistent with other sections I think I'd rather keep it above the title or by the button (on the right). We never really use it below the button, if anything above it, between that and the text :D (sorry I didn't foresee this on the original draft) |
This reverts commit 9885b29.
|
ill go to sleep and wake up in 7 hrs dm me for any changes or just dont hesitate to make any changes |
|
Can we try to put the logo here by the button? @portdeveloper Otherwise the second option you sent looks better for me |
|
|
Description
Implements the new BG client section design as per the img above
msedge_opjLqTjHpJ.mp4