Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Logo / title / subtitle #7 #23

Merged

Conversation

Okhayeeli
Copy link
Contributor

@Okhayeeli Okhayeeli commented Jun 7, 2024

Description

I changed the Logo / title / subtitle in issue #7 for Batch 6
photo_6275991944937193797_x

Additional Information

Related Issues

Closes #{7}

Your ENS/address:0x84fF709680E9378734Bae1D3B55C6568d21671c3

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch6-buidlguidl-com-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 8:07am

@Okhayeeli Okhayeeli changed the title Change to Logo / title / subtitle #7 Changes to Logo / title / subtitle #7 Jun 7, 2024
@derrekcoleman
Copy link
Member

derrekcoleman commented Jun 7, 2024

Looks great! I'll leave this open for a few more days in case anyone would like to give feedback, then we can merge 🤝

Thanks for closing the previous PR and opening a new one that focuses on just this issue 🎯

@MayowaObisesan
Copy link
Contributor

I think this looks really good.

I only have one suggestion though. Can the scaffold-eth logo be added before the #6 in the image you shared. That way the #6 shows it's for scaffold-eth without having to describe it to anyone.

@kocaemre
Copy link
Contributor

kocaemre commented Jun 7, 2024

It looks good. Great job!

@Okhayeeli
Copy link
Contributor Author

@derrekcolteman, thank you so much
@MayowaObisesan you mean like overlay this on the previous image?.
@kocaemre thank you for your review

@MayowaObisesan
Copy link
Contributor

Not overlay the image per se. I'm just suggesting that the scaffold-eth image is beside the #6 from the screenshot being shared.
I hope this is clearer.

@Okhayeeli
Copy link
Contributor Author

oh, that.. I get it now

@Okhayeeli
Copy link
Contributor Author

So, I tried to combine them together, but it does not seem to fit

@MayowaObisesan
Copy link
Contributor

That's fine @Okhayeeli . It's fine the way it is currently as well.
Let's go with what you have. 👍

@carletex carletex requested a review from derrekcoleman June 10, 2024 10:31
@derrekcoleman
Copy link
Member

Thanks for your patience, @Okhayeeli!

@carletex or @technophile-04, please merge when you have a moment.

@carletex carletex merged commit 6cb73ad into BuidlGuidl:main Jun 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants