-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add builders list #19
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks @wildanvin !! What if we move this logic, tidy a bit and create a new page for /builders
route ?
Maybe handle home page styling separately in #6 also discussing with peer's what to show on home page ?
Absolutely, I will create the builders page then. I will suggest updating the nav bar on the home page in order to access the new builders page |
Ohh yes we should def add it ! Also btw, no need to create a new PR you can revert the changes to home page by doing :
|
This reverts commit f689658.
Hello! I was about to ask you about making a new PR hehe... |
@wildanvin Looks good 🚀, But you forgot the Navbar update |
you are right! I think i will make that in a different PR |
Great job @wildanvin !!! |
Thanks @wildanvin for all the changes !!
I think it makes sense to add it in this PR itself ? It should be just couple of lines addition in |
I added the builders page in the navbar. I guess you were right @jriyyya 😅 addBuildersInNavbar.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works and looks great !! Thanks @wildanvin and also other for review !!
Awesome! thanks a lot for the feedback and explanations @technophile-04 !! |
Description
I added a list with the builders that have checked in. It displays the builder's address and an icon that takes you to the builder page.
Additional Information
Related Issues
Hopefully it will close issue #3
Your ENS/address: wildanvin.eth