Add Profile Page #44
Merged
Add Profile Page #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
phipsae
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Thanks for your personal page! Late, but glad that you did it :)
As a general advice, please ensure you create and check out a new branch (see contribution guideline, https://gist.github.com/ZakGriffith/69d1eb8baebddd7d370b87a65a7e3ec0), so that you adhere to the guidelines, which is important to contribute to open source projects. Avoid using your main branch to create a pull request.
See some comments below.
packages/nextjs/app/builders/0xafE8CB084EFfbDe745baAaaB73c80a97Ab3582a4/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0xafE8CB084EFfbDe745baAaaB73c80a97Ab3582a4/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0xafE8CB084EFfbDe745baAaaB73c80a97Ab3582a4/page.tsx
Show resolved
Hide resolved
packages/nextjs/app/builders/0xafE8CB084EFfbDe745baAaaB73c80a97Ab3582a4/page.tsx
Outdated
Show resolved
Hide resolved
|
Changes well implemented, lets merge, thanks! |
phipsae
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added profile page for issue #11
Additional Information
Related Issues
Resolves #11
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address: 0xafE8CB084EFfbDe745baAaaB73c80a97Ab3582a4