Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Implemented personal profile page for obaloluwa #21

Closed
wants to merge 8 commits into from

Conversation

obah
Copy link
Contributor

@obah obah commented Jan 9, 2025

Description

  • Added profile page for Obaloluwa 0x1C945Cd472EFBE3b34798AA49457Bc7415636E5D
  • Checked in on branch with deployment to op sepolia

Additional Information

Copy link

vercel bot commented Jan 9, 2025

@obah is attempting to deploy a commit to the BuidlGuidl Team on Vercel.

A member of the Team first needs to authorize it.

@obah obah changed the title Feat: Implemented personal profile page for oba 0x1C945Cd472EFBE3b34798AA49457Bc7415636E5D Feat: Implemented personal profile page for obaloluwa Jan 9, 2025
@derrekcoleman derrekcoleman self-requested a review January 9, 2025 15:19
Copy link
Member

@derrekcoleman derrekcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @obah! I appreciate the big visual and organized layout of the components 👌

In general, it's considered a best practice to have each branch (and pull request) have a "single responsibility". That makes it easier to understand, faster to merge, and easier to revert if it accidentally breaks anything.

This PR is about #12 and #11, so it currently has two responsibilities 😱 The good news is, you don't need to commit any code for the checkIn issue - it's just onchain 👍

Please update this PR to only have changes to your page.tsx file. Let us know if you'd like any support with git amend, git push --force, or other tools for changing a remote branch.

All-Khwarizmi and others added 6 commits January 10, 2025 21:25
- Add priority attribut to Next.js Image component to improve Largest Contentful Paint (LCP). Since the image is detected in this layer we prioritize faster loading than lazy one.
- Remove `named` export in favor of the `default` to be complaint with the NextPage type.
@obah obah closed this Jan 10, 2025
@obah obah deleted the obaloluwa.eth branch January 10, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants