Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHNX-2108: Get data for row-content for quizzes #243

Merged
merged 2 commits into from
Oct 29, 2024
Merged

PHNX-2108: Get data for row-content for quizzes #243

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bfa4b5
Add `Quizzes.viewSubmissionResults` Rel
prajapac Oct 23, 2024
77d75ea
Update Quiz `viewSubmissionResults` rel to `viewQuizSubmissionResults…
prajapac Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,8 @@ export const Rels = {
quiz: 'https://quizzes.api.brightspace.com/rels/quiz',
section: 'https://quizzes.api.brightspace.com/rels/quiz-section',
studyRecommendations: 'https://quizzes.api.brightspace.com/rels/studyRecommendations',
timing: 'https://quizzes.api.brightspace.com/rels/timing'
timing: 'https://quizzes.api.brightspace.com/rels/timing',
viewSubmissionResults: 'https://quizzes.api.brightspace.com/rels/view-quiz-submission-results'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

submission is an interesting language choice here, is there a reason we are using that instead of say viewAttemptResults.

I also don't think we need to use the word quiz in-between view and submission, we are already in the Quiz subdomain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I named it that way to be consistent with the other consts, which generally seem to match the end of the url route, e.g. questionPool for https://quizzes.api.brightspace.com/rels/quiz-question-pool etc. 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After offline discussion, we decided to name the rel const to viewQuizSubmissionResults for consistency

},
// Themes API sub-domain rels
Themes: {
Expand Down