add per-page timeout for passwordless auth #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boarnoah
reviewed
Oct 22, 2024
Comment on lines
+175
to
+176
| pageTimer.Stop(); | ||
| pageTimer.Start(); |
There was a problem hiding this comment.
Don't follow why .stop needs to be called here?
There was a problem hiding this comment.
Calling .Start() on an already started timer does nothing - it will still fire at the originally scheduled time.
We want to restart the timer here, so .Stop() must be called first to reset it.
gord5500
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an overall timeout of 15 seconds for passwordless auth, but also we should not get stuck on a single page for anywhere near that long.