remove --experimental-bypass-browser-security
#488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfbao
force-pushed
the
no-sandbox-liberally
branch
from
693f787 to
786fab1
Compare
cfbao
force-pushed
the
no-sandbox-liberally
branch
from
786fab1 to
7391cf9
Compare
cfbao
requested review from
boarnoah,
scowing,
MattPinelli,
AnimalXing and
gord5500
scowing
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
BMX inherently has to trust the org Okta domain name, so we decided it doesn't make too much sense to have an additional guard on an action that only visits the org Okta homepage.
There's also considerable less user friction and code complexity once the flag is removed.
Ticket
https://desire2learn.atlassian.net/browse/VUL-506