extract password auth into a dedicated method #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfbao
commented
Oct 17, 2024
| @@ -55,67 +55,27 @@ bool bypassBrowserSecurity | |||
| } | |||
|
|
|||
| var orgUrl = GetOrgBaseAddress( org ); | |||
| var oktaAnonymous = oktaClientFactory.CreateAnonymousClient( orgUrl ); | |||
There was a problem hiding this comment.
a side benefit of wrapping password auth in a dedicated private method is that it exposes and prevents when we declare/define variables too early, like here
cfbao
force-pushed
the
okta-auth-refactor
branch
from
943a753 to
6e91870
Compare
cfbao
force-pushed
the
okta-auth-refactor
branch
from
6e91870 to
3b7df3f
Compare
cfbao
requested review from
boarnoah,
scowing,
jharoutuniand2l,
AnimalXing and
gord5500
gord5500
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One nit I have about the current
OktaAuthenticatorclass is that it puts DSSO and password auth at different abstraction levels.This PR extracts password auth into its own dedicated private method, similar to DSSO auth.
The main public method now just shows the simple flow of "try cache -> try DSSO -> try password".