reword user-facing messages to say "passwordless" #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfbao
force-pushed
the
passwordless-wording
branch
from
5138b01 to
470682e
Compare
cfbao
commented
Oct 16, 2024
Comment on lines
-210
to
-218
| If you have to run BMX with elevated privileges, and aren't concerned with the security of {orgUrl.Host}, | ||
| consider running the command again with the '--experimental-bypass-browser-security' flag. | ||
| """ | ||
| ); | ||
| } catch( TargetClosedException ) { | ||
| consoleWriter.WriteWarning( """ | ||
| Failed to automatically sign in to Okta as BMX is likely being run with elevated privileges. | ||
| If you have to run BMX with elevated privileges, and aren't concerned with the security of {orgUrl.Host}, | ||
| consider running the command again with the '--experimental-bypass-browser-security' flag. |
There was a problem hiding this comment.
since #482, we check for elevated permission beforehand and short circuit the logic, so messages here are unnecessary
cfbao
requested review from
boarnoah,
scowing,
jharoutuniand2l,
AnimalXing and
gord5500
scowing
approved these changes
Oct 16, 2024
boarnoah
reviewed
Oct 16, 2024
| @@ -18,7 +18,7 @@ | |||
| name: "--user", | |||
| description: ParameterDescriptions.User ); | |||
|
|
|||
| // allow no-sandbox argument for chromium to for passwordless auth with elevated permissions | |||
| // allow no-sandbox argument for Chromium to for passwordless auth with elevated permissions | |||
There was a problem hiding this comment.
This message seems a bit weirdly written?
Probably should say something along the lines of how: we need to set explicitly acknowledge we have no sandboxing in elevated permissions by passing this flag
There was a problem hiding this comment.
ha, I was actually trying to fix this comment, that's why I touched "Chromium" here, but didn't end up completing the job.
will leave it be for now.
boarnoah
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We're going to brand the new feature "passwordless" rather than "auto login".
Good to use consistent language everywhere.
Ticket
https://desire2learn.atlassian.net/browse/VUL-522