replace RuntimeInformation.IsOSPlatform with OperatingSystem.Is* #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfbao
requested review from
boarnoah,
scowing,
jharoutuniand2l,
jkomonen and
gord5500
gord5500
approved these changes
Jul 26, 2024
|
How did you find this? Deprecation Warning isn't appropriate for this, but I wonder if something softer is there that .NET could have used to bring awareness. |
|
@boarnoah We were already using both APIs inconsistently within BMX, so I wondered if we should consolidate on a single one, and searched for info specifically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OperatingSystem.Is*methods are newer and more efficient. They are basically constants.A very rough check suggests that, with these new methods, the native AOT trimmer/linker can even eliminate OS-specific dead code!
See dotnet/aspnetcore#24653