fix how we find parent process #472
Conversation
github-actions
bot
added
language/csharp
area/github-actions
size/M
| $releaseUrl = gh release create "$env:RELEASE_TAG" --repo Brightspace/bmx --draft --prerelease --generate-notes --title "Release $env:RELEASE_TAG" | ||
| $releaseUrl = gh release create "$env:RELEASE_TAG" --repo Brightspace/bmx --draft --prerelease --generate-notes --title "Release $env:RELEASE_TAG" --target $env:GITHUB_SHA | ||
| } else { | ||
| $releaseUrl = gh release create "$env:RELEASE_TAG" --repo Brightspace/bmx --draft --generate-notes --title "Release $env:RELEASE_TAG" | ||
| $releaseUrl = gh release create "$env:RELEASE_TAG" --repo Brightspace/bmx --draft --generate-notes --title "Release $env:RELEASE_TAG" --target $env:GITHUB_SHA |
There was a problem hiding this comment.
unrelated fix - our release job only worked on the main branch.
| internal partial class WindowsParentProcess { | ||
| internal partial class ParentProcess { |
There was a problem hiding this comment.
Consolidated both the previous Windows and Unix classes under the same one now.
The high level method GetParentProcessName has identical logic.
| if( parentPid == -1 ) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
This is new.
GetWindowsParentProcessId returns -1 on error. We should check that, instead of passing it to GetProcessById, which will throw.
We have default fallback behaviour on each OS, so throwing doesn't make sense.
| [LibraryImport( "ntdll.dll", EntryPoint = "NtQueryInformationProcess" )] | ||
| internal static partial int NtQueryInformationProcess( |
There was a problem hiding this comment.
Moved below, as per our convention to put public/high-level methods first, and private/low-level/helper methods after.
Also changed it to private, as it's not used elsewhere.
cfbao
requested review from
boarnoah,
scowing,
jharoutuniand2l,
jkomonen and
gord5500
Why
Turns out BusyBox only implements a small portion of the POSIX spec for its ps, so our code that gets the parent process (and hence
bmx print) never worked on Alpine...(I guess no one ever used
bmx printon alpine...)Switch to use native API call, which is actually easier.
Ticket
https://desire2learn.atlassian.net/browse/VUL-403