use ANSI escape codes to control colours of parameters we print #466
Conversation
cfbao
force-pushed
the
colour
branch
2 times, most recently
from
6d5b9a5 to
2f7848c
Compare
cfbao
requested review from
boarnoah,
scowing,
jharoutuniand2l,
jkomonen and
gord5500
and removed request for
a team
| if( ( mode & ENABLE_VIRTUAL_TERMINAL_PROCESSING ) == ENABLE_VIRTUAL_TERMINAL_PROCESSING ) { | ||
| _enabled = true; | ||
| return true; | ||
| } |
There was a problem hiding this comment.
This seems to be for "its already enabled"?
| [LibraryImport( Kernel32 )] | ||
| private static partial IntPtr GetStdHandle( int nStdHandle ); |
There was a problem hiding this comment.
You sure we don't need to do SetLastError = true here?
If we are calling into un-managed code & checking if that was a success (I might be mis-understanding the purpose of that flag).
On .NET, the error information is cleared (set to 0) before invoking the callee when this field is set to true
So maybe that only applies for repeated calls with subsequent successes?
There was a problem hiding this comment.
That's only needed if you want detailed error info.
See https://learn.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.marshal.getlastpinvokeerror?view=net-8.0.
It doesn't affect a function's return value.
It's sorta like $LASTEXITCODE vs stdout in PowerShell, where even if it's not set, it doesn't affect stdout of a process.
cfbao
dismissed stale reviews from boarnoah, gord5500, and scowing
The base branch was changed.
Why
.NET's
Console.ForegroundColoronly targets stdout.If we rely on
Console.ForegroundColorand stdout is redirected (e.g.bmx print | iex), we won't get any colour on stderr either.Related .NET issue: dotnet/runtime#83146
Changing to use ANSI escape codes to control text colours to work around this issue.
Ticket
https://desire2learn.atlassian.net/browse/VUL-423
depends on #464