display okta user and org in password prompt / failed auth error message #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gord5500
requested review from
cfbao,
boarnoah,
scowing,
jharoutuniand2l and
jkomonen
gord5500
commented
Jun 12, 2024
cfbao
requested changes
Jun 12, 2024
cfbao
reviewed
Jun 12, 2024
src/D2L.Bmx/Okta/OktaApi.cs
Outdated
| @@ -23,15 +23,18 @@ internal interface IOktaApi { | |||
| internal class OktaApi : IOktaApi { | |||
| private readonly CookieContainer _cookieContainer; | |||
| private readonly HttpClient _httpClient; | |||
| private string organization = string.Empty; | |||
There was a problem hiding this comment.
Please don't initialize things to invalid non-null values just so we can mark things as non-nullable and skip null checks.
Nullables are good. Forced null checks are good. That's the compiler helping us avoid null errors.
False non-null values are much worse.
also - we name private fields with an underscore
Suggested change
| private string organization = string.Empty; | |
| private string? _organization; |
There was a problem hiding this comment.
Yea that's fair. I saw we couldn't reach the exception without having that value set already but I can see the reasoning
There was a problem hiding this comment.
related - https://desire2learn.atlassian.net/browse/VUL-104 this should help
cfbao
previously approved these changes
Jun 12, 2024
Co-authored-by: Chenfeng Bao <[email protected]>
cfbao
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Potential for the config file to have bad user / org values and it's not immediately obvious to the user that those could be the reason for their okta auth failing. This can happen with our internal install script when running wsl and the user gets set to 'root' in the config file.
Ticket
VUL-330