Use a separate const name for "unsupported/unknown MFA factors"

Brightspace · Jul 8, 2024 · 2dcb2b7 · 2dcb2b7
1 parent 19413d4
commit 2dcb2b7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/D2L.Bmx/Okta/Models/AuthenticateResponse.cs b/src/D2L.Bmx/Okta/Models/AuthenticateResponse.cs
@@ -38,7 +38,8 @@ internal record OktaMfaFactor {
 	public required string Provider { get; set; }
 	public required string VendorName { get; set; }
 
-	public const string FactorType = "unknown";
+	public const string UnsupportedMfaFactor = "unknown";
+
 	[JsonIgnore]
 	public virtual string FactorName => "unknown";
 	[JsonIgnore]

diff --git a/src/D2L.Bmx/OktaAuthenticator.cs b/src/D2L.Bmx/OktaAuthenticator.cs
@@ -57,7 +57,7 @@ bool ignoreCache
 		if( authnResponse is AuthenticateResponse.MfaRequired mfaInfo ) {
 			OktaMfaFactor mfaFactor = consolePrompter.SelectMfa( mfaInfo.Factors );
 
-			if( mfaFactor.FactorName == OktaMfaFactor.FactorType ) {
+			if( mfaFactor.FactorName == OktaMfaFactor.UnsupportedMfaFactor ) {
 				throw new BmxException( "Selected MFA not supported by BMX" );
 			}