Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for duplicate entries appearing #681

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eku
Copy link

@eku eku commented Jan 19, 2025

Utilize the value to distinguish parameter boxes, rather than relying on the position of box within the options.
This resolves the issue of duplicate entries appearing.

Solves #654, #623, #549 and probably more.

You have to edit "DoNotTouch.json" once and remove duplicate entries.

rather than relying on the position of box within
the options.
This resolves the issue of duplicate entries
appearing.
@Blueforcer
Copy link
Owner

But this doesn't solve any freeze or reboot issues like you said in the other comment, right?

Anyway, the current Webserver will be obsolete in v1.0 because I currently writing my own Webserver instead of using the library

@eku
Copy link
Author

eku commented Jan 19, 2025

But this doesn't solve any freeze or reboot issues like you said in the other comment, right?

No, I do not mix different topics in one commit.

I currently writing my own Webserver

Then use the correction as a suggestion to avoid making the same mistakes again.

@Blueforcer
Copy link
Owner

Then use the correction as a suggestion to avoid making the same mistakes again.

The new one has nothing to do with this lib and will work completely different.

@Blueforcer
Copy link
Owner

But maybe you can add the pull request to the original lib

https://github.com/cotestatnt/esp-fs-webserver

@eku
Copy link
Author

eku commented Jan 20, 2025

But maybe you can add the pull request to the original lib

I would, but the error is in the code you added. Correct me if I'm wrong.

@Blueforcer
Copy link
Owner

No, I haven't, there would be no reason to.
The creator of the lib has also revised it in the meantime.

https://github.com/cotestatnt/esp-fs-webserver/blob/cd6007fe61a1a6f4aaaa938609b141f89c44fad7/src/esp-fs-webserver.h#L178

@eku
Copy link
Author

eku commented Jan 20, 2025

Thanks for pointing me to the right revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants